Requests (UXPROD-790)

[CIRC-1371] post to /circulation/requests without request date returns error but changes item status Created: 21/Aug/19  Updated: 19/Jul/22  Resolved: 17/Feb/22

Status: Closed
Project: mod-circulation
Components: None
Affects versions: None
Fix versions: 23.0.2, 23.1.0
Parent: Requests

Type: Bug Priority: P3
Reporter: Michelle Suranofsky Assignee: Roman Barannyk
Resolution: Done Votes: 0
Labels: support
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Attachments: PNG File screenshot-1.png     PNG File screenshot-2.png     PNG File screenshot-3.png    
Issue links:
Defines
defines UXPROD-3418 Vega - Morning Glory Enhancements/Bu... Closed
Sprint: EPAM-Veg Sprint 133
Story Points: 3
Development Team: Vega
Release: Lotus R1 2022
Epic Link: Requests

 Description   

UPDATE (2021-10-04):

This issue appears to have gotten lost. I've confirmed that the reported behavior still exists and actually occurs if the fulfilmentPreference value is incorrect, as well. For example:

Attempt to post the following payload to folio-snapshot to replicate the originally-reported behavior:

{
    "requestType": "Page",
    "fulfilmentPreference": "Hold Shelf",
    "requesterId": "bec20636-fb68-41fd-84ea-2cf910673599",
    "itemId": "23fdb0bc-ab58-442a-b326-577a96204487",
    "pickupServicePointId": "3a40852d-49fd-4df2-a1f9-6e2641a6e91f"
}

Ensure that the item with barcode: 653285216743 is in status "Available"

To replicate the issue with "fulfilmentPreference", attempt to post this payload:

{
    "requestType": "Page",
    "fulfilmentPreference": "Hold shelf",
    "requesterId": "bec20636-fb68-41fd-84ea-2cf910673599",
    "itemId": "23fdb0bc-ab58-442a-b326-577a96204487",
    "pickupServicePointId": "3a40852d-49fd-4df2-a1f9-6e2641a6e91f"
}

Again, make sure the item is in status "Available"

 

ORIGINAL REPORT

If you attempt to create a request without a request date the service returns an error and does NOT create the request but it does change the item status to Paged (for a previously 'available' item)

To recreate:
POST to
http://localhost:9130/circulation/requests
using an available item without a 'requestDate':

{ "requestType": "Page", "fulfilmentPreference": "Hold Shelf", "requesterId": "99999999-9999-9999-9999-999999999901", "itemId": "e06ed2da-efd2-42a1-b4ca-eae2c672a70a", "pickupServicePointId": "29faacf1-4ba4-42c7-8b2a-566b259e4641" }

The return is:

{
"errors": [{
"message": "may not be null",
"type": "1",
"code": "-1",
"parameters": [

{ "key": "requestDate", "value": "null" }

]
}]
}

However, the item status is changed to Paged



 Comments   
Comment by Ann-Marie Breaux (Inactive) [ 04/Oct/21 ]

Hi Brooks Travis Looks like you're PO for requests now? This bug was on the UXPROD project, and it's ancient. I moved it to UIREQ, and it may not even repro any more. If it does repro, it may belong on a BE project instead of UI. In any event, I just wanted to bring it to your attention to clean up or close. Thank you!

Comment by Brooks Travis [ 04/Oct/21 ]

Well, well, well… looks like this is still an issue. It also seems to be a more general problem.

Comment by Brooks Travis [ 04/Oct/21 ]

Stephanie Buck I've assigned this to Vega. I thought it might be something that could be addressed as part of the work on title-level requests. Let me know if your team disagrees. I'm going to say that it's not a high priority item, since it's been sitting there for two years and no one else has reported it.

Comment by Stephanie Buck [ 06/Oct/21 ]

Thanks for checking this out Brooks Travis. I just chatted with the team and we'll likely treat this as a regular P4 bug, with the hopes that some of the TLR backend work might make this issue obsolete. If we encounter it in the course of our work, we'll definitely fix it then, though. 

Comment by Anya [ 29/Nov/21 ]

Support: Brooks Travis/Stephanie Buck any update on this ?

Comment by Brooks Travis [ 29/Nov/21 ]

Stephanie Buck Do we want to go ahead and move it from UIREQ to CIRC?

Comment by Stephanie Buck [ 29/Nov/21 ]

Hey Brooks Travis. Not sure I remember why we'd move it, but if you think that's the way to go, please go ahead and move it. 

Comment by Brooks Travis [ 29/Nov/21 ]

It’s a back-end issue, not UI.

Comment by Anya [ 06/Dec/21 ]

Support: Michelle Suranofsky is this currently happening - looking at the open date - it was opened in 2019. 

Comment by Michelle Suranofsky [ 06/Dec/21 ]

Anya - I'm not sure.  I think I ran into this working on the NCIP module.  I can test it?

Comment by Michelle Suranofsky [ 06/Dec/21 ]

Anya - it looks like in October someone updated this Jira description and confirmed it is still happening.

Comment by Anya [ 06/Dec/21 ]

Thanks Michelle Suranofsky we were looking at the  date filed and were wondering 

Comment by Anya [ 20/Dec/21 ]

Support: Michelle Suranofsky should this be pumped in priority? 

Comment by Michelle Suranofsky [ 20/Dec/21 ]

Anya - I don't 'think' so.  I only ran across this accidentally when working with the API for mod-ncip.

Comment by Brooks Travis [ 20/Dec/21 ]

I agree with @msuranofsky. That said, Stephanie Buck, we might run this by the Vega devs to see if it’s addressable as part of the TLR updates to mod-circulation (i.e., “while you’re in there…”). It’s not high priority, but it may as well not persist if the logic that results in this bug is being worked on, anyway.

Comment by Anya [ 10/Jan/22 ]

Support: Brooks Travis confirms that this is still happening- CC Michelle Suranofsky and Stephanie Buck this will come into play with backend coding - and will impact development. 

Comment by Stephanie Buck [ 11/Jan/22 ]

Anya, I've bumped the priority here to a P3. 

Comment by Anya [ 24/Jan/22 ]

Support: Stephanie Buck is there a release target? 

Comment by Roman Barannyk [ 17/Feb/22 ]

Tested on snapshot, the validation for requestDate and fulfilmentPreference works as expected:


Comment by Charlotte Whitt [ 20/Jun/22 ]

Support SIG: This ticket is scheduled for Lotus R1 2022, but says it is Awaiting deployment. Stephanie Buck will you take a look at see, what might be missing here? And if all is good, then please close the ticket. Thanks a ton.

Generated at Fri Feb 09 00:20:23 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.