[CIRC-1300] Without Calendar permissions, check-ins do not calculate overdues Created: 04/Oct/21 Updated: 06/Dec/23 Resolved: 14/Oct/21 |
|
| Status: | Closed |
| Project: | mod-circulation |
| Components: | None |
| Affects versions: | None |
| Fix versions: | 22.1.1, 23.0.0 |
| Type: | Bug | Priority: | P1 |
| Reporter: | Ian Walls | Assignee: | Viktor Draban |
| Resolution: | Done | Votes: | 0 |
| Labels: | support | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||||||||||
| Issue links: |
|
||||||||||||||||||||
| Sprint: | EPAM-Veg Sprint 125 | ||||||||||||||||||||
| Story Points: | 2 | ||||||||||||||||||||
| Development Team: | Vega | ||||||||||||||||||||
| Release: | R3 2021 Bug Fix | ||||||||||||||||||||
| Affected Institution: |
Cornell, MO State, TAMU, Warner
|
||||||||||||||||||||
| Tester Assignee: | Holly Mistlebauer | ||||||||||||||||||||
| Description |
|
To Fix: Add calendar.opening-hours.collection.get as a subpermission to ui-checkin.all Overview: Warner University had noticed that when their student workers checked in overdue materials, fines were not calculating as expected. When staff did, the fine calculated. Research found that this was due to the Student Worker permission set missing calendar.opening-hours.collection.get permission The fine policy that was being applied had 'Count closed days/hours/minutes' set to 'no'. So it makes sense that the calendar was being consulted, but invisibly preventing fines from calculating because the user did not have calendar permissions seems like unintended behavior. Steps to Reproduce:
Expected Results: Overdues calculate and are charged to the patron according to the terms defined in the overdue fine policy defined in step 2 Actual Results: No fines are calculated Interested parties: ByWater Solutions |
| Comments |
| Comment by Erin Nettifee [ 04/Oct/21 ] |
|
Anne L. Highsmith - this seems remarkably similar to the errors you were seeing this summer. Did you ever find out what permission didn't have this that was needed? Ian Walls what permissions do the student workers actually have in check in? Can you provide the permission set? I feel like this should be easy to fix. |
| Comment by Anne L. Highsmith [ 04/Oct/21 ] |
|
Erin Nettifee Yeah, it's exactly the same error and the same permission. I just added the perm to all the perm sets that had discharge privs. |
| Comment by Erin Nettifee [ 05/Oct/21 ] |
|
OK. There's just one permission in ui-checkin, so the fix here is pretty simple, and I have outlined it above. But you could also make the fix in existing environments by doing what Anne L. Highsmith has suggested. |
| Comment by Anya [ 11/Oct/21 ] |
|
Support - Holly Mistlebauer Stephanie Buck not sure what team it needs to go to - on the team's page in the wiki it looks like the one we have assigned. |
| Comment by Stephanie Buck [ 11/Oct/21 ] |
|
Anya and Holly Mistlebauer, ui-checkin is a Vega module, with Cheryl Malmborg as PO. (ui-checkout is Prokopovych.) I'll change this to Vega and add it to the top of our backlog. |
| Comment by Erin Nettifee [ 11/Oct/21 ] |
|
I just want to note that there is a workaround for this - you can use the developer option to make hidden permissions visible, and add calendar.opening-hours.collection.get to any relevant users or permission sets. So while I don't disagree that this is a bad bug, I don't know that it's worth a P1. Just my two cents. |
| Comment by Amy Blumenthal [ 11/Oct/21 ] |
|
I looked at the hiddens and although I saw a bunch of "collection get" sorts of permissions, I didn't see calendar.opening-hours.collection.get. I think it might have been called that in Honeysuckle. Now that one of our higher-level admins has taken care of adding the permission, I see that in Iris it translates to a "friendly name" of "List calendar opening hours". |
| Comment by Brooks Travis [ 11/Oct/21 ] |
|
In principle, I agree, Erin Nettifee, but I think that the timing and what should be the relative ease of fixing this, together with the potential impact, justifies a P1 for Kiwi Bug Fix. We're not looking at releasing this as a Juniper hotfix, are we? |
| Comment by Stephanie Buck [ 11/Oct/21 ] |
|
Vega can likely get this included for Kiwi Bug Fix. |
| Comment by Alina Dorosh [ 14/Oct/21 ] |
|
Hello Holly Mistlebauer! Work as expected on Snapshot env. Note: User has no permissions: Settings (Calendar): Can create, view, and edit calendar events, Settings (Calendar): Can create, view, edit, and remove calendar events, Settings (Calendar): Can view calendar events and circ-admin permission set |
| Comment by Anne L. Highsmith [ 14/Oct/21 ] |
|
Hi, Holly Mistlebauer. I'm not entirely sure of the import of Alina's message above, but if it means that a user has to have Settings permissions just to discharge an item and have a correct fine charged, I don't think that's what the community would want. You don't want to have to give student workers settings permissions just to get basic functionality to work. |
| Comment by Holly Mistlebauer [ 14/Oct/21 ] |
|
Anne L. Highsmith: For student workers you would use Settings (Calendar): Can view calendar events. The other two permissions (Settings (Calendar): Can create, view, and edit calendar events and Settings (Calendar): Can create, view, edit, and remove calendar events are for administrators. |
| Comment by Holly Mistlebauer [ 14/Oct/21 ] |
|
Thanks...now we have to have this added to Kiwi BugFest... |
| Comment by Erin Nettifee [ 14/Oct/21 ] |
|
That display name is confusing — I think it should change. |
| Comment by Marc Johnson [ 21/Oct/21 ] |
|
Alexander Kurash Viktor Draban I'm starting to prepare a 22.1.1 release for 2021 R3 Bug Fix, would you like me to back port this and include it? |
| Comment by Alexander Kurash [ 22/Oct/21 ] |
|
Marc Johnson Yes Marc, please include it if possible |