Epic to link all support issues located in Dev projects (SUP-12)

[CIRC-1194] Wrong calculation of the due date when there is a an exceptional closed period Created: 28/Jul/21  Updated: 02/Sep/21  Resolved: 02/Sep/21

Status: Closed
Project: mod-circulation
Components: None
Affects versions: None
Fix versions: None
Parent: Epic to link all support issues located in Dev projects

Type: Bug Priority: P1
Reporter: Annalisa Di Sabato Assignee: Unassigned
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Attachments: Microsoft Word CIRC-1194 doubts.docx     PNG File New attachment.png     PNG File image-2021-07-28-15-27-36-099.png     PNG File image-2021-07-28-15-27-57-663.png     PNG File image-2021-07-28-15-28-31-564.png     PNG File screenshot-1.png    
Issue links:
Blocks
is blocked by CIRC-1202 SPIKE: Investigate wrong calculation ... Closed
Cloners
is cloned by CIRC-1202 SPIKE: Investigate wrong calculation ... Closed
Sprint:
Development Team: Vega
Affected Institution:
BNCF
Epic Link: Epic to link all support issues located in Dev projects

 Description   

In BNCF production and test enviroment (Iris Q1 2021) the due date of an item doesn't consider the  exceptional closed period.

 

Step to reproduce:

  1. Logged in https://bncf-test.folio.ebsco.com/  (it's the BNCF Folio test)
  2. Went into Settings - Calendar
  3. Selected SP: SP-Sala lettura
  4. Selected Open calendar to add exceptions and added a new exception period from the 22nd of july to the end of month
  5. Went in to the Checkout app, entered user with barcode CF0235310 and item barcode 006015858 (the loan policy is set for 7 days)
  6. The due date of the item is 5th of August

Expected: The due date should consider the exceptional closed period and it should be the 9th of August

Actual: The due date of the item is 5th of August



 Comments   
Comment by Anya [ 09/Aug/21 ]

Support: Cheryl Malmborg is there an update on this - thanks. This is listed as a p1 which is to be fixed right away. 

Comment by Alexander Kurash [ 12/Aug/21 ]

Cheryl Malmborg We started investigating this bug and there seems to be confusion about how exception periods should work, so we'd like to get clarification from you.

From the ticket description, it looks like BNCF expect that when the library is closed during loan time due to exception period, loan's due date should be extended by the amount of time the library was closed. But this is not how closed library due date management works, at least from our understanding. Due date can be moved according to the selected closed library due date management rule (like Move to the end of the next open day etc.) if the library is closed at that particular time, but we don't extend it by adding a sum of all of the closed periods between now and then. Exceptional closed periods, we thought, are just exceptions to the calendar. For example, if the library was open according to its regular schedule set up in the calendar, it may become closed on a particular day due to exceptional period. But this doesn't change how closed library due date management works - closed period is a closed period, no matter if it's coming from a regular calendar or from an exceptional period. We tested this behavior and it seems to be working on Snapshot.

I can see three possibilities here:

  1. We don't fully understand how calendar and exception periods are supposed to work.
  2. We didn't understand what was the issue - maybe BNCF meant that it should be moved from 5th to 9th for some other reason.
  3. Everything works as it should, but in this case there's another question - should we change this behavior (in which case it is a feature) or should we leave it as is?

In any case, we're going to need Cheryl Malmborg's help with this one.

Comment by Cheryl Malmborg [ 12/Aug/21 ]

Alexander Kurash Your understanding of how exceptional periods work is correct. The description of the problem does not specify the date the item was loaned. It does appear that it was loaned during the exception period when the library was closed. I think this is a misunderstanding.

Comment by Annalisa Di Sabato [ 13/Aug/21 ]

Hi all,

I'm bit confused. i try to explain what I expect to get, giving you an example:

I loan the item 004925940 to patron with  barcode CF0235310. The loan policy is set for 7 days.

The loan Action date is  8/13/2021, 09:39 and the loan Due date is  8/21/2021, 23:59 (see the new attachment).

If you check the calendar for  the SP Sala lettura, you'll notice that the library is closed on Sunday: this means that the system will consider the closed day in the calculation of the due date, that it is 21st of August instead of 20th.

So, if the system, to calculate the due date, considers the closed day set in the calendar, I'm expecting that it will consider also the exceptional closed period.

Alexander Kurash if you go in the test environment you can see that the item was loaned on 28/7/2021, 15:20. 

Moreover the problem it's not related to the loan done during the exception period when the library is closed, because Erin Nettifee explained me that it's possible to loan an item also during the library closed period. 

My doubts are related to the closed days: are the closed days excluded from the calculation of the due date of an item or not? 

Is it possible to have a document where it's explained well how the system calculates the due date and what kind of impact has the calendar (with its closed days, exceptional closed period) on it? 

Thanks for your support

 

 

Comment by Roman Barannyk [ 18/Aug/21 ]
I loan the item 004925940 to patron with  barcode CF0235310. The loan policy is set for 7 days.

The loan Action date is  8/13/2021, 09:39 and the loan Due date is  8/21/2021, 23:59 (see the new attachment).

If you check the calendar for  the SP Sala lettura, you'll notice that the library is closed on Sunday: this means that the system will consider the closed day in the calculation of the due date, that it is 21st of August instead of 20th. 

I've been working on investigation of this issue and figured out that a due date should be moved to the end of the next day open day in case of the due date is closed day. Considering the schedule on BNCF Folio test, SP Sala lettura, there are closed days only on Sundays. I guess only an exception day could cause the due date moving, and then it could be removed, because as we can see in closed loans, in hour later the similar loan was made with expected calculated due date 8/20/2021.

 

My doubts are related to the closed days: are the closed days excluded from the calculation of the due date of an item or not?

No, the closed days are not excluded from the calculation except the case when the due date falls on a closed day. If the due date falls on a closed day, the due date will be moved according to the chosen strategy ("Move to the end of the next open day" or "Move to the end of the previous open day") or it will be kept as it is for "Keep the current due date strategy".

 

Is it possible to have a document where it's explained well how the system calculates the due date and what kind of impact has the calendar (with its closed days, exceptional closed period) on it?

Yes, the requirements for the closed library due date management are here: UICHKOUT-451 Closed

Comment by Stephanie Buck [ 20/Aug/21 ]

Annalisa Di Sabato, please see Roman's answers to your questions above. Is this a bug, or is this related to functionality that you'd like to see in FOLIO, ie, an improvement to current functionality?

Comment by Stephanie Buck [ 30/Aug/21 ]

Support (Anya & Debra Howell), can we have some assistance here please? Annalisa Di Sabato, how should we move forward with this ticket?

Comment by Annalisa Di Sabato [ 31/Aug/21 ]

Hi Stephanie Buck,

 

sorry, but I'm back yesterday from summer vacation. Anyway, before answering, yesterday I tried to do some test to verify the behaviour of the Due date considering the calendar setting, but I'm having some problems in the BNCF tests environment with the calendar setting of SP-Sala consultazione. I have already notified it to the Ebsco support, but I'm waiting for an answer. I'm sorry, but I want to make sure that everything is working properly as you indicated. Thanks

Comment by Stephanie Buck [ 31/Aug/21 ]

Thank you, Annalisa Di Sabato. I hope you had an enjoyable vacation! 

Comment by Annalisa Di Sabato [ 31/Aug/21 ]

Dear Stephanie Buck, thanks. It was a very pleasant vacation!

In the meantime, I reproduced the workflow into Folio snapshot environment, but perhaps I'm doing something wrong, because the system returns an unclear message (for me of course) when I tried to loan an item for a week to a patron. Please, see the attachment ( CIRC-1194 Closed doubts.docx).

Thanks for your support

 

Comment by Stephanie Buck [ 31/Aug/21 ]

Roman Barannyk, can you take a look at the most recent attachment from Annalisa Di Sabato? I'm not sure if this relates to the bug as reported, or if it's a different issue. 

Comment by Roman Barannyk [ 02/Sep/21 ]

Annalisa Di Sabato it seems like you created a schedule in the calendar for Circ Desk 1 service point, but you are trying to check-out the item on Online service point. The calendar timetable is absent for the chosen service point...

Comment by Annalisa Di Sabato [ 02/Sep/21 ]

Roman Barannyk thanks for yur explanation. Thanks, now I'm able to loan the item. 

I did my tests and you can close the thicket.

Thanks for your support

 

Comment by Stephanie Buck [ 02/Sep/21 ]

Not a bug. 

Generated at Thu Feb 08 22:21:52 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.