[CIRC-1139] Request pick up notice not sent to requester when requester's barcode has been changed after request was created Created: 23/Apr/21  Updated: 08/Jul/21  Resolved: 20/May/21

Status: Closed
Project: mod-circulation
Components: None
Affects versions: None
Fix versions: 20.1.6, 22.0.0

Type: Bug Priority: P2
Reporter: Lisa Sjögren Assignee: Oleksandr Vidinieiev
Resolution: Done Votes: 0
Labels: support
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Attachments: PNG File image-2021-04-23-15-55-37-956.png     File request_object_retains_obsolete_requester_barcode.json    
Issue links:
Relates
relates to CIRC-1149 Hotfix release v20.1.6 Closed
relates to FOLIO-2473 When requester barcode is changed in ... Closed
relates to UIU-1370 Link from Users to Requests Doesn't W... Closed
Sprint: EPAM-Veg Sprint 115, EPAM-Veg Sprint 113, EPAM-Veg Sprint 114
Story Points: 2
Development Team: Vega
Release: R1 2021 Hot Fix #1
CSP Approved: Yes
CSP Request Details: Approved as R1 2021 Hot Fix #1 if Chalmers fall semester starts before September 1. Otherwise could wait until Juniper.
Affected Institution:
Chalmers

 Description   

Update:  Approved as R1 2021 Hot Fix #1 if Chalmers fall semester starts before September 1. Please see Marie's comment below as they will not be updated to Juniper before their fall semester begins so a Hotfix is required.

Overview: No request pick up notice is sent (or even generated?) to the requester if the requester's user barcode has been changed after the request was created. 

Originally reported in: Chalmers Honeysuckle, verified in https://folio-snapshot.dev.folio.org/ 2021-04-23.
Reporting library priority: Important. This is a bug that affects patrons directly.

 
Preconditions:

A notice policy set to send Pick up notices when a request gets status Open - Awaiting pickup

Steps to Reproduce:

  1. Go to the Requests app, and create a request for user 12345
  2. Got to the Check in app, and check the item in
  3. Go to the Circulation log, and verify that a Pick up notice has been sent to user 12345. The notice has been sent.
  4. Make a GET request to okapi-url/email to verify that a Pick up notice has been delivered to user 12345. The email has been delivered.
  5. Cancel the request
  6. Go to the Requests app, and create a new request for user 12345
  7. Go to the Users app, and change the user's barcode to to 12345edit
  8. Got to the Check in app, and check the item in
     

Expected Results:

Go to the Circulation log, and verify that a Pick up notice has been sent to user 12345edit. The notice has been sent.

Make a GET request to okapi-url/email to verify that a Pick up notice has been delivered to user 12345edit. The email has been delivered.

Actual Results:

Go to the Circulation log to verify that a Pick up notice has been sent to user 12345. No Pick up notice is displayed in the circulation log.

Make a GET request to okapi-url/email to verify that a Pick up notice has been delivered to user 12345edit. There is no pickup email for this request, neither delivered or failed.

Additional Information:
I know that the fact that the original barcode of the requester is saved in the request object, and not updated by subsequent edits to the user, has previously caused problems. Linking those issues in case there is a link. Also attaching a file with objects from request-storage showing how obsolete user data is saved in the request.

URL: https://folio-snapshot.dev.folio.org/
Interested parties:
Marie Widigson



 Comments   
Comment by Anya [ 26/Apr/21 ]

Support -

  • Does mod users - know about the mod circ - the notice of the change might not get to the circ communication. 
  • Darcy Branchini and julie.bickle will try to recreate. 
  • How often does the barcode change? 
Comment by Darcy Branchini [ 28/Apr/21 ]

I was able to reproduce this on Iris. cc: Oleksandr Vidinieiev

Comment by Darcy Branchini [ 29/Apr/21 ]

Lisa Sjögren, this bug is in Code Review now. How frequently are users' barcodes changed? I'm trying to get a feel for the need for a Honeysuckle hotfix versus a fix in the Iris release.

Comment by Lisa Sjögren [ 29/Apr/21 ]

Hi Darcy Branchini! Great to hear that it's already in code review.

I'll let Marie Widigson, who originally reported this from Chalmers, speak to how often users' barcodes are changed.

Comment by Marie Widigson [ 29/Apr/21 ]

Hi!
Great that you have fixed this bug so quickly!

This time of the year this scenario should not be too common. However, during the beginning of the autumn semester it will happen a lot more frequently. We currently are not sure when we will be able to implement Iris before the start of the semester or not, as summer vacations are complicating it. Can we get back about this next week when we may know more about the upgrade?

There is another just reported related bug about pick up notices that is way more common https://folio-org.atlassian.net/browse/SUP-38

Comment by Marie Widigson [ 06/May/21 ]

Hi Darcy Branchini It will be enough to get this as an Iris hotfix when we upgrade at the beginning of July. Thanks!

Comment by Darcy Branchini [ 11/May/21 ]

Need to get approval. Scheduled to discuss this at the next Capacity Planning meeting on Monday, 5/17.

Comment by Marc Johnson [ 11/May/21 ]

Darcy Branchini

Need to get approval. Scheduled to discuss this at the next Capacity Planning meeting on Monday, 5/17.

If this hasn't been approved for a patch release, please can the status of this be either Closed or In Review, as it isn't waiting for release (and Oleksii Petrenko asked me to receive notifications for issues in this status and I would prefer not to receive false notices if possible)

cc: Holly Mistlebauer

Comment by Darcy Branchini [ 17/May/21 ]

Marie Widigson will you be updated to Juniper before your autumn semester? And/or when does your autumn semester start? Thank you!

Comment by Debra Howell [ 17/May/21 ]

Holly Mistlebauer From SUPPORT SIG: Your "red" note from Capacity Planning said "R2 2021 Hot Fix" we think you mean R1 2021 Hot Fix #1 and updated the note to reflect that because of the noted Release Date. If we are incorrect, please update. Thanks!

Comment by Marie Widigson [ 18/May/21 ]

We would need this as a hotfix for Iris. (We will definitely not upgrade to Juniper before the Autumn semester starts.) Thanks!

Comment by Marie Widigson [ 08/Jul/21 ]

Thank you for fixing this bug, I can verify that it works fine in Chalmers' Iris now! 

Generated at Thu Feb 08 22:21:39 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.