[CIRC-1003] SPIKE: Investigate behavior of "dueDateChangeByRecall" Created: 10/Nov/20  Updated: 17/Nov/20  Resolved: 16/Nov/20

Status: Closed
Project: mod-circulation
Components: None
Affects versions: None
Fix versions: None

Type: Story Priority: P2
Reporter: Cate Boerema (Inactive) Assignee: Bohdan Suprun (Inactive)
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Issue links:
Relates
relates to CIRC-1018 Modify logic for setting "dueDateChan... Closed
Sprint: Core: F - Sprint 101
Development Team: Prokopovych

 Description   

There is a property called dueDateChangeByRecall

Questions:

  • Is this set only when a recall actually changes the due date? Or when the first recall is applied to a loan?
    • Context: it is possible for a recall to not affect the due date (for example, if the recall comes in 3 days before the due date and the recall return interval is 3 days) and, in such cases, you really still need to know that the item has been recalled (for the purposes of fee/fines and notices)
  • Is this set when there is a recall in an item queue before the loan is created?
    • Context: if there is a queue of recalls on an item before it is checked out, the loan is automatically truncated at checkout. So the due date doesn't really change, but it is still important to track that the item has been recalled.
  • Is this set when a recall is moved to an item currently on loan (assuming the loaned item hasn't already been recalled)?
    • Context: I think it should be set in this case.
  • Is this UNset when the last recall on an item is moved to another item or cancelled?
    • Context: I am pretty sure the answer to this is no. While some institutions definitely like the idea of "giving back" time to borrowers when a recall is cancelled or moved, we decided to postpone this work due to the complexity.
  • Where is this property used?
    • Context: For example, is this used to determine when to charge a borrower the recalled and overdue fee/fine? Is it used to determine when a loan action history record is written? Etc.
  • Anything else that is interesting that you think we should know. Thanks!


 Comments   
Comment by Bohdan Suprun (Inactive) [ 11/Nov/20 ]

Hi Cate Boerema,

Is this set only when a recall actually changes the due date? Or when the first recall is applied to a loan?

It is set when the first recall is applied to a loan regardless dueDate is changed or not.

Is this set when there is a recall in an item queue before the loan is created?

Yes, if the first request in the queue is RECALL then the logic is applied and the flag is set.

Is this set when a recall is moved to an item currently on loan (assuming the loaned item hasn't already been recalled)?

Yes, it is set

Is this UNset when the last recall on an item is moved to another item or cancelled?

No, it is never unset

Where is this property used?

  • It is used on checkout to truncate due date if there is a recall in the queue;
  • It is used when recall request is created/moved for/to loaned item;
  • It is used to calculate overdue fine (overdue recall fine is used in this case vs overdue fine for noŃ‚ recalled loans);
  • It is also used to decide whether to ignore grace period when overdue fine is calculated;
  • It is used for patron blocks
Comment by Cate Boerema (Inactive) [ 11/Nov/20 ]

This is the BEST news! Thank you so much Bohdan Suprun!

Yes, if the first request in the queue is RECALL then the logic is applied and the flag is set.

What if item A has this queue:
1. Hold for User X
2. Hold for User Y
3. Recall for User Z

When the item is checked out to User X, will the flag be set? I think it should be, but I wasn't sure because you are saying here "if the first request in the queue..."

Comment by Bohdan Suprun (Inactive) [ 11/Nov/20 ]

Cate Boerema,

As far as I see the logic checks only the top request. But let me test it on env.

Comment by Bohdan Suprun (Inactive) [ 11/Nov/20 ]

Cate Boerema,

Hmm... is it possible to have hold requests for an available item?

Comment by Bohdan Suprun (Inactive) [ 11/Nov/20 ]

Cate Boerema,

Ok, it seems it is possible if item is In transit. So yes, the flag has NOT set if the recall is 3rd in the queue.

Comment by Cate Boerema (Inactive) [ 11/Nov/20 ]

Ok, it seems it is possible if item is In transit. So yes, the flag has NOT set if the recall is 3rd in the queue.

Interesting! I think we'll need to change that. How big of a change do you think that would be (story points)?

Comment by Bohdan Suprun (Inactive) [ 11/Nov/20 ]

Should not be a big one, 3-5 story points.

Comment by Bohdan Suprun (Inactive) [ 16/Nov/20 ]

Hi Cate Boerema,

Should I resolve and close the spike?

Comment by Cate Boerema (Inactive) [ 16/Nov/20 ]

Yes. This spike can be closed. Thanks so much for investigating this, Bohdan Suprun!

Generated at Thu Feb 08 23:23:51 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.