[BF-224] Loan Type Created by [User] not populated Created: 11/Mar/22  Updated: 08/Apr/22

Status: Draft
Project: Bug Fest
Components: None
Affects versions: None
Fix versions: None

Type: Story Priority: TBD
Reporter: julie.bickle Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: reviewed
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Attachments: PNG File Lotus_LoanTypeCreatedBy.png     PNG File Skärmavbild 2022-03-11 kl. 4.12.05 em.png     PNG File Skärmavbild 2022-03-11 kl. 4.15.31 em.png     PNG File Skærmbillede 2022-03-29 kl. 12.14.52.png     PNG File Skærmbillede 2022-03-29 kl. 12.15.43.png     PNG File Skærmbillede 2022-04-04 kl. 12.54.10.png     JPEG File Snapshot_LoanTypeCreatedBy.JPG    
Issue links:
Relates
relates to FOLIO-3447 user metadata fields are absent for r... Closed
Sprint:
RCA Group: TBD

 Description   

Overview:

In Lotus, when I created a new loan type, the name of my user (in this case: Julie Bickle), did not appear in the settings.

This could NOT be replicated in Snapshot.

Steps to Reproduce:

  1. Log into Lotus Bugfest
  2. Settings >> Inventory >> Loan Type
  3. Create a new loan type
  4. New loan type is created!

Expected Results:

I see that is it created by "Julie Bickle"

Actual Results:

The loan type is created by [blank].

Additional Information:
URL:
Interested parties:



 Comments   
Comment by Charlotte Whitt [ 11/Mar/22 ]

Dilshod_Khusanov - what Julie describe is:

This is https://bugfest-lotus.int.aws.folio.org/settings/inventory/loantypes

And when checked if the bug could be verified in FOLIO Snapshot (3/11/2022) then the two test loan type (using the account DIKU ADMINISTRATOR) are correct logged:

I see that almost all Settings Reference values are not correct identified - see e.g. also Settings > Inventory > Instances > Format
https://bugfest-lotus.int.aws.folio.org/settings/inventory/formats, where it only says "12/18/2019 by" [and then nothing]

where the correct implementation is like here in uChicago's test environment:

Comment by Charlotte Whitt [ 14/Mar/22 ]

Marc Johnson Michal Kuklis - the KitFox team continue to put this back to be the responsibility of Prokopovych.
I believe this is a Bugfest environment issue, but maybe you have better luck to explain that for Dilshod_Khusanov.

See the implementation for uChicago - that is how it should look like:

Comment by Michal Kuklis [ 14/Mar/22 ]

julie.bickle and Dilshod_Khusanov the issue here is that the pre-populated data does not include all metadata required for this to work correctly. Here is what we see:

 

{
  "loantypes" : [{
    "id" : "d901ea9c-0abe-44fe-aa81-305560eed277",
    "name" : "tripod",
    "metadata" : {
      "createdDate" : "2019-12-18T20:46:34.000+00:00",
      "updatedDate" : "2019-12-18T20:46:34.000+00:00"
    }
  }, {
    "id" : "b853b7bb-26f4-4309-a98b-374d007e21e3",
    "name" : "vidcam",
    "metadata" : {
      "createdDate" : "2019-12-18T20:46:34.000+00:00",
      "updatedDate" : "2019-12-18T20:46:34.000+00:00"
    }
  }, {
    "id" : "b67c65b4-1f5d-4f04-b16b-3a0c7f54564b",
    "name" : "yerk",
    "metadata" : {
      "createdDate" : "2019-12-18T20:46:34.000+00:00",
      "updatedDate" : "2019-12-18T20:46:34.000+00:00"
    }
  }, {
    "id" : "a302f13b-0368-4839-8fe7-3592fee4049a",
    "name" : "参考外借本",
    "metadata" : {
      "createdDate" : "2020-11-23T09:56:42.980+00:00",
      "createdByUserId" : "455328e7-1461-450a-a5dc-023c064d4e9c",
      "updatedDate" : "2020-11-23T09:56:42.980+00:00",
      "updatedByUserId" : "455328e7-1461-450a-a5dc-023c064d4e9c"
    }
  }, {
    "id" : "8a86b680-2834-4c42-8d25-92253400c19d",
    "name" : "普通外借本",
    "metadata" : {
      "createdDate" : "2020-11-23T09:56:34.956+00:00",
      "createdByUserId" : "455328e7-1461-450a-a5dc-023c064d4e9c",
      "updatedDate" : "2020-11-23T09:56:34.956+00:00",
      "updatedByUserId" : "455328e7-1461-450a-a5dc-023c064d4e9c"
    }
  }, ... ],
  "totalRecords" : 124
}

As you can see some records are missing  "createdByUserId" and "updatedByUserId".

These will have to be populated in order for this to work correctly.

This could be potentially an issue with the initial seed/migration/reference data or it could be a backend issue (we see a similar issue in snapshot env).

Zak Burke will create a ticket for devops to review this issue in snapshot.

Comment by Dilshod_Khusanov [ 15/Mar/22 ]

Michal Kuklis, thank you for finding the possible issue.

Charlotte Whitt, Oleksii Petrenko, Vitaly Demchenko we discussed BF tickets with Kitfox a few times already, and it is clear that responsible dev. teams as per Scope table have to take a look at it first and tell Kitfox that the problem is with backend code/data or the environment.

Comment by Charlotte Whitt [ 24/Mar/22 ]

Hi Michal Kuklis and Zak Burke - how can we help Kitfox to fix this. Right now this keep sticking to the Prokopovych team, but it is a devops issue, when loading the reference data.

Zak Burke - I believe you filed a FOLIO ticket or do I remember wrong here?

CC: Oleksii Petrenko

Comment by Marc Johnson [ 24/Mar/22 ]

Charlotte Whitt

how can we help Kitfox to fix this. Right now this keep sticking to the Prokopovych team, but it is a devops issue, when loading the reference data.

This is NOT a DevOps issue with the loading of reference data.

As Julian Ladisch and Wayne Schneider explained in FOLIO-3447 Closed , even if the reference data is loaded via the intended route (enabling the module in Okapi, which then makes requests to the relevant module's tenant API).

This is a limitation of the design of that aspect of the system. No created by user can be assigned because the system does not know which user performed these actions.

This is why reloading the reference data (as I believe the KitFox team have been trying to do) won't help resolve this.

If we want to workaround / hide this issue, then these fields could be set by manipulating the data in the database manually. Only the KitFox team can do this workaround for the Bug Fest environments.

This won't resolve the underlying challenge and will reoccur for future reference and sample records created by modules until the design limitation is resolved.

Zak Burke - I believe you filed a FOLIO ticket or do I remember wrong here?

That is FOLIO-3447 Closed . It is linked from this issue.

cc: Jakub Skoczen Dilshod_Khusanov Oleksii Petrenko

Comment by Dilshod_Khusanov [ 28/Mar/22 ]

According to Marc Johnson's comment, it is "a limitation of the design of that aspect of the system".

julie.bickle, can you review that.

Comment by julie.bickle [ 29/Mar/22 ]

I created the bug, but I believe Charlotte Whitt is better suited to review Marc's comment.

Comment by Marc Johnson [ 29/Mar/22 ]

Dilshod_Khusanov julie.bickle Charlotte Whitt

My comment is a reflection of my understanding of what Julian Ladisch and Wayne Schneider have stated on FOLIO-3447 Closed . And the immediate options available to folks.

I'm not stating any opinion on whether we should change / remove the limitation described.

Comment by Charlotte Whitt [ 29/Mar/22 ]

Dilshod_Khusanov Marc Johnson - I can see that not even the work around has been implemented, and the information created by is still missing from

Bugfest Lotus

FOLIO Snapshot

Please notice that FOLIO-3447 Closed user metadata fields are absent for reference and sample data is CLOSED as Won't do.
At this point of the Bugfest test, then we probably should close this bug ticket as well as Won't do.

To mee it seems like the TC need to decide how can we resolve this looking forward, and the TC need to circle back to their previous conversation re. these questions. Marc Johnson you are in the TC will you take on this task?

Comment by Marc Johnson [ 29/Mar/22 ]

Charlotte Whitt

I can see that not even the work around has been implemented, and the information created by is still missing from

I don't think the workaround should be done without an explicit product decision, as in effect, it only hides the limitation on this specific environment (so production environments still won't have that information even if we do this).

Please notice that FOLIO-3447 Closed user metadata fields are absent for reference and sample data is CLOSED as Won't do.

It is. I have already asked Zak Burke (who closed it) for help understanding what that means. It could mean that we've decided we won't address the limitation or it could mean that we won't do the workaround.

At this point of the Bugfest test, then we probably should close this bug ticket as well as Won't do.

Sure. Much like FOLIO-3447 Closed I think we need to be very explicit about what we mean when we say we won't do this.

Folks could easily interpret (like I did initially with FOLIO-3447 Closed ) closing both of these as won't do as meaning that we have chosen not to change / remove / address the limitation.

To me it seems like the TC need to decide how can we resolve this looking forward, and the TC need to circle back to their previous conversation re. these questions. Marc Johnson you are in the TC will you take on this task?

I am happy to bring this to the TC.

I'm not sure I'm the most appropriate person to do so, given this limitation is a fundamental platform level decision, which would suggest to me it might be better considered by the Core Platform folks.

Jakub Skoczen if you would prefer to bring this to the TC, then please let me know.

I will say that I think this falls into a bit of a grey area, I don't think we will necessarily have agreement on whether this is a TC concern.

Comment by Marc Johnson [ 30/Mar/22 ]

Charlotte Whitt julie.bickle

Before I take this topic to the Technical Council (on Charlotte Whitt's request), I would like to make sure I understand what the product expectations are.

My interpretation of what folks want is:
ALL reference and sample records (created by modules) MUST have a created by user that is specified at the point of installation (when the module is enable for the tenant).

How far wrong is that?

I want to make sure that folks understand this as a decision that affects the whole product.

cc: Khalilah Gambrell Zak Burke

Comment by Marc Johnson [ 31/Mar/22 ]

Charlotte Whitt Dilshod_Khusanov julie.bickle

To be explicit, I'm not doing anything with the Charlotte Whitt's request above until the relevant product decisions are made and we have a shared understanding of the expectations.

cc: Owen Stephens Khalilah Gambrell (copied in because of the conversation in the PO channel on Slack)

Comment by Charlotte Whitt [ 01/Apr/22 ]

I'll change the ticket into Draft, and take it off the Bugfix Lotus timeline. Hopefully I can get an answer from PO's on how we should proceed while this affects all apps using reference data.
You are off the hook for now Marc Johnson

Comment by Charlotte Whitt [ 04/Apr/22 ]

Oleksii Petrenko - will you move this work out of the Lotus Bugfest Dashboard - right now we need feed back from the POs (CC: Khalilah Gambrell) and/or might need the work into a decision pipeline by the TC.

Thanks!

Comment by Charlotte Whitt [ 08/Apr/22 ]

Oleksii Petrenko - please see the comment above

Generated at Thu Feb 08 22:22:19 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.