Issues

Select view

Select search mode

 
22 of 22

relocate ui-testing platform tests to platform-core

Done

Description

It would be nice to see ui-testing have no dependencies on Stripes UI modules. It does so today because ui-testing is acting both as a test framework as well as the integration platform of sorts.

Tests that span multiple apps would be better kept within a platform which defines those apps under test, like folio-testing-platform. This would leave ui-testing's responsibility as a testing framework only.

The advantage of this separation is that ui-testing can then be incorporated into other tools, like Stripes-CLI without pulling down the entire app ecosystem. Further, by having platform tests kept with a platform, we can define and maintain tests that may be unique to different platforms. Organizationally, this is much like how we have app tests that are kept with each app.

Environment

None

Potential Workaround

None
100% Done
Loading...

Checklist

hide

TestRail: Results

Details

Assignee

Reporter

Priority

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created March 30, 2018 at 8:40 PM
Updated November 13, 2018 at 3:44 PM
Resolved September 6, 2018 at 12:32 PM

Activity

Show:

Zak BurkeSeptember 6, 2018 at 12:32 PM

ui-testing has been renamed to stripes-testing and the contents of tests moved from this repository to platform-core. Thus, this repository can now function solely as a test framework without any dependencies on UI modules, and integration tests which do depend on multiple UI modules are located in a platform which already includes them.

Mike TaylorAugust 28, 2018 at 2:33 PM

I'm in favour – though I don't feel strongly about, and could be argued around if others disagree.

Jira (the issue tracker) would have no problems at all with ui-testing being renamed stripes-testing. Probably one piece of config would need tweaking. could do it in his sleep.

Matt JonesAugust 28, 2018 at 2:30 PM

As noted by on Slack today:

Aside; it's probably a bug that ui-testing is so named, since the ui-* prefix otherwise indicates a Stripes module. Ought to be called something like stripes-testing.

And given we will need to release ui-testing#framework-only branch on its own,

We will then release a version of ui-testing that is the framework-only and update the dependency in stripes-cli which is currently pointing to a branch.

perhaps we do so under a new repo, stripes-testing, and deprecate ui-testing in the process. This may simplify releases going forward. Would this cause any headaches from issue tracking or other perspectives?

My first thought with renaming "ui-testing" is that all the current ui-* modules test directories are already named as such (/test/ui-testing), but this is minor. The directories would not have to change.

I don't mean to further extend scope here, but if this is something we should do, this seems to be the appropriate time to do so.

John MalconianAugust 27, 2018 at 6:45 PM
Edited

I copied the latest changes (as of Aug 27) to ui-testing/tests/*.js from master to 'platform-core@FOLIO-1344-jenkins' and modified the scripts to use the UI testing context (uiTestCtx). Also did some basic linting. I think there is an outstanding PR on ui-testing that is not accounted for yet which consists of migrating new_proxy.js from ui-users to the platform suite of tests.

https://github.com/folio-org/ui-testing/pull/67

Once outstanding PRs are merged, we may want to consider making the repo read-only or perhaps designate one or two people who can make changes.

I need to finish testing of the CI changes required to invoke the UI integration tests during the nightly builds from platform core (currently run from ui-testing). Once that is complete, we need to update migrate folio-testing-platform for nightly builds to platform-complete. After that, all further UI integration test updates can be made to platform-core. We will then release a version of ui-testing that is the framework-only and update the dependency in stripes-cli which is currently pointing to a branch. After that, all further UI integration test updates can be made to platform-core.

Jakub SkoczenAugust 22, 2018 at 1:44 PM

reassigning to Zak while Matt is on vaca in order to enable progress on FOLIO-1358

TestRail: Cases
TestRail: Runs