New job profiles sometimes include actions from previously-created job profiles

Description

Overview: When creating multiple job profiles in the same session, actions that I have assigned to one job profile become associated with a following job profile

Steps to Reproduce:

  1. Log into FOLIO-snapshot as diku_admin

  2. Go to Settings/Data import/Job profiles

  3. Create a new job profile 1 and assign a match or two, and several actions

  4. Keep track of which matches/actions you assign to the new job profile 1

  5. Save the new job profile 1

  6. Create another new job profile 2 and assign a match or two, and several actions. They don't have to be the same or different from ones you assigned to new job profile 1

  7. Keep track of which matches/actions you assign to the new job profile 2

  8. Save the new job profile 2

  9. View the details of job profile 2 (in View and Edit mode)

  10. View the details of job profile 1 (in View and Edit mode)

Expected Results: Job profile 1 should only have the matches and actions that were assigned to job profile 1. Job profile 2 should only have the matches and actions that were assigned to Job profile 2.

Actual Results: Job profile 2 includes actions that were assigned to Job profile 1. Job profile 1 includes actions that were assigned to Job profile 2. I'm not sure if it's happening with matches too.

Additional Information: See attached video

A-M NOTE: when testing this bugfix, also test that unlinking Action profiles actually causes them to be removed, and that match profiles are not removed

Add query param "jobProfileId" with corresponding jobProfile id to request GET /data-import-profiles/profileSnapshots/{profileId} to retrieve snapshot tree for any jobProfile or matchProfile.
Fill in "jobProfileId" in profileAssociation when creating associations matchProfile to matchProfile and matchProfile to actionProfile.

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Attachments

5

Checklist

hide

TestRail: Results

Activity

Show:

Ann-Marie BreauxMay 4, 2020 at 8:11 AM

Hi Tested on folio-snapshot, and all is beautiful! The legos have been unglued from each other. Thank you! Closing this bug

Ann-Marie BreauxApril 6, 2020 at 1:35 PM

Hi yes, there was a PR, but there was a misunderstanding about how it should work - so it's not correct yet. there's a backend blocker to figure out how to fix it. I'll dig it up and link it.

Cate BoeremaApril 6, 2020 at 12:46 PM

is Blocked the correct status for this? Looks like the linked blocker is closed. Also there was a PR issued?

Ann-Marie BreauxApril 2, 2020 at 6:31 AM

I checked with the librarian group yesterday, and they agreed. The same action profile may be used more than once in the same job profile. But no one could think of any use cases where the same match profile might be used more than once in the same job profile.

So I think it's safe to assume:

  • any particular match profile can only be used once in a particular job profile

  • any particular action profile (and its associated field mapping profile) could be used more than once in a particular job profile

Please let me know if any questions. Thank you!

Ann-Marie BreauxApril 1, 2020 at 2:57 PM

Blocked until reviews architecture with to figure out how to decouple match and action profiles until they are put together into a job profile

Done

Details

Assignee

Reporter

Priority

Story Points

Sprint

Development Team

Folijet

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created February 26, 2020 at 3:47 PM
Updated May 4, 2020 at 8:12 AM
Resolved May 4, 2020 at 8:12 AM
Loading...