Update node.js version from 10 to 14
Description
CSP Request Details
None
CSP Rejection Details
None
Potential Workaround
None
relates to
Checklist
hideTestRail: Results
Activity
Show:
Mike Taylor December 1, 2021 at 11:32 AM
OK, thanks, that is solid.
Julian Ladisch December 1, 2021 at 11:02 AM
Node v10 has exceeded end-of-life since 2021-04-30 so that it doesn't receive security fixed and therefore should no longer been used for production code.
Mike Taylor December 1, 2021 at 10:46 AM
Ah, I see – a deep dependency introduced a node>=12 requirement two weeks ago, for no obvious reason. (If anything, they needed node>1.5.0)
https://github.com/flickr/incoming-message-hash/commit/148437d60c6fc6a8f979d29aa7912f51bfd604ba#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R6-R8
That seems a silly reason to impose the requirement on the whole of mod-graphql. I think pinning incoming-message-hash to the known-good v4.0.0 might be a better play.
What do you think?
Mike Taylor December 1, 2021 at 10:31 AM
Do we know why this has suddenly started being a problem?
Done
Details
Details
Assignee
Mike TaylorReporter
Julian LadischPriority
TBDDevelopment Team
Thor
TestRail: Cases
Open TestRail: Cases
TestRail: Runs
Open TestRail: Runs
Created November 30, 2021 at 10:29 PM
Updated December 1, 2021 at 11:33 AM
Resolved December 1, 2021 at 11:33 AM
TestRail: Cases
TestRail: Runs
The Jenkins build pipeline of the pull request https://github.com/folio-org/mod-graphql/pull/65 fails with this error message:
https://jenkins-aws.indexdata.com/blue/organizations/jenkins/folio-org%2Fmod-graphql/detail/MODGQL-141-json-ptr-3.0.0/2/pipeline/
https://jenkins-aws.indexdata.com/blue/organizations/jenkins/folio-org%2Fmod-graphql/detail/PR-65/1/pipeline/
Solution: Switch node.js version from 10 to 14. FOLIO usually uses node.js 14.