'Maximum outstanding fee/fine balance' automated patron block not going in effect when it should after changing patron's Patron Group

Description

Overview:
Outstanding fees/fines from before patron changed to a Patron Group with a limit are not being counted. In my case I had a patron with over $4,000.00 in fees/fines. After changing her Patron Group to 'Alum, quarter 25', I had to add an additional $200 in fees/fines before the block would appear. I also had a patron with $50.00 in fees/fines. After changing his Patron Group to 'Alum, quarter 25' and adding 101.00 in new fees/fines, the block did not appear. I had to add $50.00 more in fees/fines to get the block to appear.

Steps:

  1. Login to https://bugfest-goldenrod.folio.ebsco.com/

  2. Go to Settings>Users>Patron blocks

    • Set Conditions for 'Maximum outstanding fee/fine balance' to block everything

    • Set Limits for Patron Group 'Alum, quarter 25' so that 'Maximum outstanding fee/fine balance' is 150

  3. Find a patron with that is not currently in Patron Group 'Alum, quarter 25', who already has over 150.00 in outstanding fees/fines (you cannot do the fees/fines today, they have to be from previous days)

  4. Now change the patron's Patron Group to 'Alum, quarter 25'

  5. The 'Maximum outstanding fee/fine balance' should now go into effect, but it doesn't

  6. Charge patron 151.00 in new fees/fines

  7. Go to User Information for the patron and see that the 'Maximum outstanding fee/fine balance' patron block is now in effect

Expected results:
Described above

Actual results:
Described above

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Attachments

5

Checklist

hide

TestRail: Results

Activity

Show:

Holly MistlebauerJuly 28, 2020 at 6:34 PM

Holly tested this at https://bugfest-goldenrod.folio.ebsco.com/ using a fresh user (one that has never been used before in testing fees/fines) and discovered that this error cannot be reproduced. The test users she was using became corrupt from other bugs that have since been fixed.

Oleksandr VidinieievJuly 28, 2020 at 6:14 PM

, yes, it should work.

Holly MistlebauerJuly 28, 2020 at 6:06 PM

: If I pick a user on https://bugfest-goldenrod.folio.ebsco.com/ that has never had fees/fines and test this on him/her, it should work? I will try this now.

Oleksandr VidinieievJuly 28, 2020 at 12:15 PM
Edited

, Tested on Bugfest. Changing the patron group does make the block appear/disappear as long as new or "clean" (without previously created fees/fines) user is used. Failure to do the same for users with old fees/fines is to be expected. Here is why:

  • Every time a fee/fine is created/updated/closed, a corresponding event is fired. At mod-patron-blocks we collect those events and use their payload to create and maintain a "user profile" of sorts. This profile tells us what fees/fines a patron owns, and this is the information we use to calculate automated blocks for the patron.

  • We can't just call mod-feesfines directly and see what fees/fines the patron owns, due to limitations of FOLIO platform.

  • Reliability of this approach depends completely on synchronicity of data between mod-feesfines and mod-patron-blocks.

  • This approach will fail if you use a patron who owns fees/fines which were created before we started collecting events.

This is the case with the patron you used for testing: their "profile" currently is out of sync with data stored in mod-feesfines. It's the same issue with corrupt data that can't be cleared that we see in . The block was created, but not cleared properly due to a bug that was fixed at a later date. We'll continue to see these so it's best to test patron blocks with new users instead of blocks previously created. We could also consider a new feature that allows a user to clear them.

Cannot Reproduce

Details

Assignee

Reporter

Tester Assignee

Priority

Story Points

Sprint

Development Team

Vega

Release

Q2 2020 Hot Fix #1

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created July 2, 2020 at 7:27 PM
Updated October 8, 2020 at 3:37 PM
Resolved July 28, 2020 at 6:34 PM
Loading...